Re: [PATCH] rev-parse: fix --parse-opt --keep-dashdash --stop-at-non-option
- From
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
- Date
- Jul 8, 2010, 06:51 UTC
- Message-ID
- <20100708065118.GA21565@pengutronix.de>
- In-Reply-To
- <7vr5jfrmuq.fsf@alter.siamese.dyndns.org>
On Wed, Jul 07, 2010 at 02:41:33PM -0700, Junio C Hamano wrote:
Show 10 quoted lines
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: > > > The ?: operator has a lower priority than |, so the implicit associativity > > made the 6th argument of parse_options be PARSE_OPT_KEEP_DASHDASH if > > keep_dashdash was true discarding PARSE_OPT_STOP_AT_NON_OPTION and > > PARSE_OPT_SHELL_EVAL. > > Wow, this is an age-old breakage dating back to 6e0800e (parse-opt: make > PARSE_OPT_STOP_AT_NON_OPTION available to git rev-parse, 2009-06-14) that > dates back to the very original --stop-at-non-option patch, isn't it?
Yeah, the author of 6e0800e should get a pat on his head and a lesson in C. :-)
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |