Re: [PATCH 1/8] Refactor parse_loc
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 14, 2010, 23:20 UTC
- Message-ID
- <7vr5dkq6vf.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <201012150006.12462.trast@student.ethz.ch>
Thomas Rast <trast@student.ethz.ch> writes:
Show 23 quoted lines
> Junio C Hamano wrote: >> Thomas Rast <trast@student.ethz.ch> writes: >> > +test_expect_success 'blame -L parses end' ' >> > + git blame -L1,1 tres >out && >> > + cat out && >> > + test $(wc -l < out) -eq 1 >> > +' >> >> What does this test exactly? "end"? > > That's the test I was referring to in the commit message: > > The new test is for a case that made me pause during debugging: the > 'blame -L with invalid end' test was the only one that noticed an > outright failure to parse the end *at all*. So make a more explicit > test for that. > > So I guess a more thorough test title would be > > blame -L parses <end> part of its argument > > IOW, the test verifies that -L1,1 is not parsed the same as -L1, which > would result in *two* lines of output.
Oh the comment definitely was misleading. It made me think that "-L1,1" was a typo of "-L1,$" which was the new feature in the patch.