Re: [PATCH 1/8] Refactor parse_loc

From: Thomas Rast <trast@student.ethz.ch>
Date: Dec 14, 2010, 23:06 UTC
Message-ID: <201012150006.12462.trast@student.ethz.ch>
In-Reply-To: <7v8vzsrmhk.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

Show 8 quoted lines

> Thomas Rast <trast@student.ethz.ch> writes:
> > +test_expect_success 'blame -L parses end' '
> > +	git blame -L1,1 tres >out &&
> > +	cat out &&
> > +	test $(wc -l < out) -eq 1
> > +'
> 
> What does this test exactly?  "end"?

That's the test I was referring to in the commit message:

  The new test is for a case that made me pause during debugging: the
  'blame -L with invalid end' test was the only one that noticed an
  outright failure to parse the end *at all*.  So make a more explicit
  test for that.

So I guess a more thorough test title would be

  blame -L parses <end> part of its argument

IOW, the test verifies that -L1,1 is not parsed the same as -L1, which would result in *two* lines of output.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch