Re: [PATCH] Change include order in two compat/ files to avoid compiler warning

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 5, 2012, 20:41 UTC
Message-ID: <7vr4y9ggij.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1328404107-15757-1-git-send-email-bwalton@artsci.utoronto.ca>

Ben Walton <bwalton@artsci.utoronto.ca> writes:

> The inet_ntop and inet_pton compatibility wrapper source files
> included system headers before git-compat-utils.h.

Thanks, that is definitely a breakage.

Show 16 quoted lines

> diff --git a/compat/inet_ntop.c b/compat/inet_ntop.c
> index 60b5a1d..f1bf81c 100644
> --- a/compat/inet_ntop.c
> +++ b/compat/inet_ntop.c
> @@ -15,11 +15,9 @@
>   * SOFTWARE.
>   */
>  
> +#include "../git-compat-util.h"
>  #include <errno.h>
>  #include <sys/types.h>
> -
> -#include "../git-compat-util.h"
> -
>  #include <stdio.h>
>  #include <string.h>

I actually have to wonder if any of these four inclusion of the system headers are warranted. Wouldn't they be included as part of git-compat-util.h anyway?