(unknown)

From: Ben Walton <bwalton@artsci.utoronto.ca>
Date: Feb 5, 2012, 22:32 UTC
Message-ID: <1328481141-21037-1-git-send-email-bwalton@artsci.utoronto.ca>
In-Reply-To: <7vr4y9ggij.fsf@alter.siamese.dyndns.org>

Hi Junio,

Show 20 quoted lines

> > diff --git a/compat/inet_ntop.c b/compat/inet_ntop.c
> > index 60b5a1d..f1bf81c 100644
> > --- a/compat/inet_ntop.c
> > +++ b/compat/inet_ntop.c
> > @@ -15,11 +15,9 @@
> >   * SOFTWARE.
> >   */
> >
> > +#include "../git-compat-util.h"
> >  #include <errno.h>
> >  #include <sys/types.h>
> > -
> > -#include "../git-compat-util.h"
> > -
> >  #include <stdio.h>
> >  #include <string.h>
> 
> I actually have to wonder if any of these four inclusion of the
> system headers are warranted. Wouldn't they be included as part of
> git-compat-util.h anyway?

Yes, you're correct. Dropping the system includes is correct as opposed to rearranging the order. Updated patch to follow.

Thanks -Ben