Re: [PATCH 03/65] i18n: archive: mark parseopt strings for translation

From: Junio C Hamano <gitster@pobox.com>
Date: May 29, 2012, 20:31 UTC
Message-ID: <7vr4u23f0i.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1338203657-26486-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 5 quoted lines

> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  rc times are usually more quiet times, let's slip the series in..
>  minor conflict with revert topic in pu, but should be easy to
>  resolve.

"Yes", "no", and "does not matter".  I can buy this, though:

    Let's show this early, so that others are aware of this effort,
    and if they happen to be touching strings in the affected files,
    they can take one of these patches and roll it in their series
    when post 1.7.11 window opens.

Show 18 quoted lines

> diff --git a/archive.c b/archive.c
> index a484433..2584324 100644
> --- a/archive.c
> +++ b/archive.c
> @@ -7,10 +7,10 @@
>  #include "unpack-trees.h"
>  
>  static char const * const archive_usage[] = {
> -	"git archive [options] <tree-ish> [<path>...]",
> -	"git archive --list",
> -	"git archive --remote <repo> [--exec <cmd>] [options] <tree-ish> [<path>...]",
> -	"git archive --remote <repo> [--exec <cmd>] --list",
> +	N_("git archive [options] <tree-ish> [<path>...]"),
> +	N_("git archive --list"),
> +	N_("git archive --remote <repo> [--exec <cmd>] [options] <tree-ish> [<path>...]"),
> +	N_("git archive --remote <repo> [--exec <cmd>] --list"),
>  	NULL
>  };

I can understand the "help" text member of OPT_BLAH() construct, but do we really want to translate the above?