Re: [PATCH] am: invoke perl's strftime in C locale
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 14, 2013, 21:49 UTC
- Message-ID
- <7vr4ln8mgd.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20130114205933.GA25947@altlinux.org>
"Dmitry V. Levin" <ldv@altlinux.org> writes:
Show 5 quoted lines
> This fixes "hg" patch format support for locales other than C and en_*, > see https://bugzilla.altlinux.org/show_bug.cgi?id=28248 > > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> > ---
Thanks.
The reference URL is not very friendly, and you should be able to state it here on a single line in English instead, I think.
The patch looks correct, though.
Show 16 quoted lines
> git-am.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-am.sh b/git-am.sh
> index c682d34..64b88e4 100755
> --- a/git-am.sh
> +++ b/git-am.sh
> @@ -334,7 +334,7 @@ split_patches () {
> # Since we cannot guarantee that the commit message is in
> # git-friendly format, we put no Subject: line and just consume
> # all of the message as the body
> - perl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }
> + LC_ALL=C perl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }
> if ($subject) { print ; }
> elsif (/^\# User /) { s/\# User/From:/ ; print ; }
> elsif (/^\# Date /) {