git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] am: invoke perl's strftime in C locale

From
Dmitry V. Levin <ldv@altlinux.org>
Date
Jan 14, 2013, 22:36 UTC
Message-ID
<20130114223651.GA26443@altlinux.org>
In-Reply-To
<7vr4ln8mgd.fsf@alter.siamese.dyndns.org>

This fixes "hg" patch format support for locales other than C and en_*. Before the change, git-am was making "Date:" line from hg changeset metadata according to the current locale, and this line was rejected later with "invalid date format" diagnostics because localized date strings are not supported.

Reported-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
 v2: replaced "unfriendly" URL with a short description
 git-am.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-am.sh b/git-am.sh
index c682d34..64b88e4 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -334,7 +334,7 @@ split_patches () {
 			# Since we cannot guarantee that the commit message is in
 			# git-friendly format, we put no Subject: line and just consume
 			# all of the message as the body
-			perl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }
+			LC_ALL=C perl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }
 				if ($subject) { print ; }
 				elsif (/^\# User /) { s/\# User/From:/ ; print ; }
 				elsif (/^\# Date /) {
-- 
ldv
Previous: Junio C HamanoNext: Jeff King
Message 3 of 13 in “am: invoke perl's strftime in C locale”
  1. am: invoke perl's strftime in C localeDmitry V. Levin, Jan 14, 2013
  2. Junio C HamanoJan 14, 2013
  3. am: invoke perl's strftime in C localeDmitry V. Levin, Jan 14, 2013
  4. Jeff KingJan 15, 2013
  5. Antoine PelisseJan 15, 2013
  6. Jeff KingJan 15, 2013
  7. Dmitry V. LevinJan 15, 2013
  8. am: invoke perl's strftime in C localeDmitry V. Levin, Jan 15, 2013
  9. Junio C HamanoJan 18, 2013
  10. Jeff KingJan 19, 2013
  11. Dmitry V. LevinJan 19, 2013
  12. Junio C HamanoJan 20, 2013
  13. Junio C HamanoJan 15, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.