Re: [PATCH v4] submodule: add 'deinit' command

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 12, 2013, 18:03 UTC
Message-ID: <7vr4klh0k7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CABURp0oQcPotK20QcqCG1pGQPVoa4RnN2nDA=iQoKS99gnPEAQ@mail.gmail.com>

Phil Hord <phil.hord@gmail.com> writes:

Show 19 quoted lines

>> +       if test $# = 0
>> +       then
>> +               die "$(eval_gettext "Use '.' if you really want to deinitialize all submodules")"
>> +       fi
>> +
>> +       module_list "$@" |
>> +       while read mode sha1 stage sm_path
>> +       do
>> +               die_if_unmatched "$mode"
>> +               name=$(module_name "$sm_path") || exit
>> +               url=$(git config submodule."$name".url)
>> +               if test -z "$url"
>> +               then
>> +                       say "$(eval_gettext "No url found for submodule path '\$sm_path' in .git/config")"
>
> Is it safe to shelter the user a little bit more from the git
> internals here and say instead:
>
>    Submodule '\$sm_path' is not initialized.

Sounds like a sensible suggestion.

> Also, I think this code will show this message for each submodule on
> 'git submodule deinit .'  But I think I would prefer to suppress it in
> that case.  If I have not explicitly stated which submodules to
> deinit,...

But isn't it the way to explicitly say "everything under the sun"? After all, what does the message say to "git submodule deinit"?