Re: [PATCH v3 0/7] rebase.autostash completed

From: Junio C Hamano <gitster@pobox.com>
Date: May 13, 2013, 14:00 UTC
Message-ID: <7vr4hbou7d.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALkWK0mWRC9_QVYAu9Q4iAoVTpfkf9xkc9apjrdv6SyEiCq+hA@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

Show 16 quoted lines

> Junio C Hamano wrote:
>> Especially I did not check if there are
>> still undesirable data loss behaviour in corner cases that people
>> were worried about in the discussion.
>
> Check the tests.  What am I missing?
>
>>    In the longer term, it is unmaintainable to make such users (like
>>    this new code) of the stash mechanism manually do so, and we may
>>    want to add a "git stash __store" subcommand, not meant for the
>>    interactive use of end users.  The implementation of the stash
>>    can later be changed without affecting such users by doing so.
>
> Yes, a "store" that stores a commit created with "create" would be
> nice.  Why the horrible double-underscore though?  "git stash create"
> is not meant for interactive use of end users either.

"create" is not advertised very widely, but "store" is too close to what is already familiar to the people "save" and we really do not want to confuse them. "store -m message commit" sounds as if you are creating a stash to apply to the given $commit.