git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/7] am: tighten a conditional that checks for $dotest

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
May 12, 2013, 11:56 UTC
Message-ID
<1368359801-28121-2-git-send-email-artagnon@gmail.com>
In-Reply-To
<1368359801-28121-1-git-send-email-artagnon@gmail.com>

In preparation for a later patch that creates $dotest/autostash in git-rebase.sh before anything else happens, don't assume that the presence of a $dotest directory implies the existence of the $dotest/next and $dotest/last files. Look for them explicitly.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 git-am.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/git-am.sh b/git-am.sh
index c092855..ccb854a 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -446,6 +446,8 @@ done
 # If the dotest directory exists, but we have finished applying all the
 # patches in them, clear it out.
 if test -d "$dotest" &&
+   test -f "$dotest/last" &&
+   test -f "$dotest/next" &&
    last=$(cat "$dotest/last") &&
    next=$(cat "$dotest/next") &&
    test $# != 0 &&
@@ -454,7 +456,7 @@ then
    rm -fr "$dotest"
 fi
 
-if test -d "$dotest"
+if test -d "$dotest" && test -f "$dotest/last" && test -f "$dotest/next"
 then
 	case "$#,$skip$resolved$abort" in
 	0,*t*)
-- 
1.8.3.rc1.51.gd7a04de
Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 2 of 22 in “rebase.autostash completed”
  1. 0/7 rebase.autostash completedRamkumar Ramachandra, May 12, 2013
  2. 1/7 am: tighten a conditional that checks for $dotestRamkumar Ramachandra, May 12, 2013
  3. 2/7 rebase -i: don't error out if $state_dir already existsRamkumar Ramachandra, May 12, 2013
  4. 3/7 rebase: prepare to do generic housekeepingRamkumar Ramachandra, May 12, 2013
  5. 4/7 am: return control to caller, for housekeepingRamkumar Ramachandra, May 12, 2013
  6. 5/7 rebase -i: return control to caller, for housekeepingRamkumar Ramachandra, May 12, 2013
  7. 6/7 rebase --merge: return control to caller, for housekeepingRamkumar Ramachandra, May 12, 2013
  8. 7/7 rebase: implement --[no-]autostash and rebase.autostashRamkumar Ramachandra, May 12, 2013
  9. Junio C HamanoMay 13, 2013
  10. Ramkumar RamachandraMay 13, 2013
  11. Junio C HamanoMay 13, 2013
  12. Ramkumar RamachandraMay 13, 2013
  13. Matthieu MoyMay 13, 2013
  14. Ramkumar RamachandraMay 13, 2013
  15. Matthieu MoyMay 13, 2013
  16. Junio C HamanoMay 13, 2013
  17. Ramkumar RamachandraMay 13, 2013
  18. Matthieu MoyMay 13, 2013
  19. Junio C HamanoMay 13, 2013
  20. Junio C HamanoMay 13, 2013
  21. Ramkumar RamachandraMay 13, 2013
  22. Junio C HamanoMay 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.