Re: [PATCH] Add -B flag to diff-* brothers.

PB> Actually, I like this one - contrary to -O I can see how this could be PB> quite useful - I have wished for this many times when people would send PB> me some "complete rewrite" patches which I actually wanted to review.

PB> Please don't give up on it. :-)

Well, although I do not do Porcelain ;-), I do want to have -O to help my use pattern. I envision that Porcelain noticing the existence of ${GIT-.git}/patch-order file and adding -O to its diff-* argument would make the world a better place.

And I am not giving up on -B yet, but as you can imagine, it has interesting interaction with -M/-C, since rename detection code must be prepared to deal with broken pairs (earlier it did not have to worry about the same path that is a regular file appearing twice in its input). Since I have tested -B only in the context of full set of patches I sent out, and have not tested it with only the subset Linus decided to swallow, I would recommend against applying it on top of the Linus tip as is. I'll be rebasing it to his tip, test it again and then resubmit later. I'll do the same for -O changes.