Re: [PATCH] Add -B flag to diff-* brothers.

From: Petr Baudis <pasky@ucw.cz>
Date: May 29, 2005, 21:56 UTC
Message-ID: <20050529215617.GT1036@pasky.ji.cz>
In-Reply-To: <7vbr6vrvqf.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Sat, May 28, 2005 at 09:33:44PM CEST, I got a letter where Junio C Hamano <junkio@cox.net> told me that...

Show 14 quoted lines

> This introduces diffcore-break.c, a new diffcore
> transformation.
> 
> When the -B flag is given, a patch that represents a complete
> rewrite is broken into a deletion followed by a creation.  This
> makes it easier to review such a complete rewrite patch.
> 
> The -B flag takes the same syntax as the -M and -C flags to
> specify the maximum amount of source material the resulting file
> can still have to be considered a complete rewrite, and defaults
> to 15% if not specified.  For example, this detects the complete
> rewrite of ls-tree.c I sent earlier.
> 
> Signed-off-by: Junio C Hamano <junkio@cox.net>

Actually, I like this one - contrary to -O I can see how this could be quite useful - I have wished for this many times when people would send me some "complete rewrite" patches which I actually wanted to review.

Please don't give up on it. :-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor