Re: [PATCH] Make git-update-cache --force-remove regular

From: Junio C Hamano <junkio@cox.net>
Date: May 31, 2005, 19:52 UTC
Message-ID: <7vpsv7xjf2.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20050531165243.GD7013@pasky.ji.cz>

>>>>> "PB" == Petr Baudis <pasky@ucw.cz> writes:

PB> Make the --force-remove flag behave same as --add, --remove and PB> --replace. This means I can do

PB> 	git-update-cache --force-remove -- file1.c file2.c

PB> which is probably saner and also makes it easier to use in cg-rm.

I am ambivalent about this. Although I like the semantic clean-up your proposed change makes, at the same time:

  $ git-update-cache --force-remove one --add two

used to remove "one" and add "two", which has to be now written as two separate calls, which is a slight a performance hit of having to read the 1.6MB cache twice. Maybe it does not matter, or the new usage's convenience outweighs it; I cannot tell offhand.