Re: [PATCH] Make git-update-cache --force-remove regular

From: Petr Baudis <pasky@ucw.cz>
Date: May 31, 2005, 20:41 UTC
Message-ID: <20050531204155.GH7013@pasky.ji.cz>
In-Reply-To: <7vpsv7xjf2.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Tue, May 31, 2005 at 09:52:17PM CEST, I got a letter where Junio C Hamano <junkio@cox.net> told me that...

Show 19 quoted lines

> >>>>> "PB" == Petr Baudis <pasky@ucw.cz> writes:
> 
> PB> Make the --force-remove flag behave same as --add, --remove and
> PB> --replace. This means I can do
> 
> PB> 	git-update-cache --force-remove -- file1.c file2.c
> 
> PB> which is probably saner and also makes it easier to use in cg-rm.
> 
> I am ambivalent about this.  Although I like the semantic
> clean-up your proposed change makes, at the same time: 
> 
>   $ git-update-cache --force-remove one --add two
> 
> used to remove "one" and add "two", which has to be now written
> as two separate calls, which is a slight a performance hit of
> having to read the 1.6MB cache twice.  Maybe it does not matter,
> or the new usage's convenience outweighs it; I cannot tell
> offhand.

Sort all the forced removals to the end. I think it's still better than

  git-update-cache --force-remove one --force-remove two \
	--force-remove three ...

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor