git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix unconditional early exit in cg-fetch

From
Junio C Hamano <junkio@cox.net>
Date
Dec 20, 2005, 01:15 UTC
Message-ID
<7vpsnso9g8.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20051219161736.18245.98591.stgit@zion.home.lan>
Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> writes:
Show 7 quoted lines
>  	if [ "$get" = "get_rsync" ]; then
>  		$get -i -s -u -d "$uri/refs/tags" "$_git/refs/tags" ||
> -			echo "unable to get tags list (non-fatal)" >&2
> -		exit $?
> +			(echo "unable to get tags list (non-fatal)" >&2;
> +			exit $?)
>  	fi

Why would you want a subshell that exits with a non-zero status when nobody is checking that status anyway?

I suspect removing "exit $?" would suffice, if that condition is non-fatal as the message says...

Previous: Paolo 'Blaisorblade' GiarrussoNext: Blaisorblade
Message 2 of 3 in “Fix unconditional early exit in cg-fetch”
  1. Fix unconditional early exit in cg-fetchPaolo 'Blaisorblade' Giarrusso, Dec 19, 2005
  2. Junio C HamanoDec 20, 2005
  3. BlaisorbladeDec 20, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.