From: Junio C Hamano <junkio@cox.net>
Date: Tue, 20 Dec 2005 01:15:19 GMT
Subject: Re: [PATCH] Fix unconditional early exit in cg-fetch
Message-ID: <7vpsnso9g8.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20051219161736.18245.98591.stgit@zion.home.lan>

Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> writes:

>  	if [ "$get" = "get_rsync" ]; then
>  		$get -i -s -u -d "$uri/refs/tags" "$_git/refs/tags" ||
> -			echo "unable to get tags list (non-fatal)" >&2
> -		exit $?
> +			(echo "unable to get tags list (non-fatal)" >&2;
> +			exit $?)
>  	fi

Why would you want a subshell that exits with a non-zero status
when nobody is checking that status anyway?

I suspect removing "exit $?" would suffice, if that condition is
non-fatal as the message says...