Re: [PATCH] t9500: skip gitweb tests if perl version is too old

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 23, 2007, 10:14 UTC
Message-ID: <7vps3n3rm7.fsf@assigned-by-dhcp.pobox.com>
In-Reply-To: <20070623085751.GX955MdfPADPa@greensroom.kotnet.org>

Sven Verdoolaege <skimo@kotnet.org> writes:

Show 18 quoted lines

> On Fri, Jun 22, 2007 at 11:31:40PM -0700, Junio C Hamano wrote:
>> Sven Verdoolaege <skimo@kotnet.org> writes:
>> > +perl -MEncode -e 'decode_utf8("", Encode::FB_CROAK)' >/dev/null 2>&1 || {
>> > +    test_expect_success 'skipping gitweb tests, perl version is too old' :
>> > +    test_done
>> > +    exit
>> > +}
>> > +
>> 
>> Hmph.  Even something silly like:
>> 
>> 	perl -MEncode -e 'decode_utf8("", Encode::FB_CLUCK)'
>> 
>> seem to succeed for me with 5.8.8.
>> 
>
> Maybe I'm missing something, but it's supposed to succeed
> for perl versions that are recent enough.

Well, "Encode::FB_CLUCK" is a bogus symbol even in recent Perl. IOW, the tested function does not seem to care if I give whatever garbage as the second parameter.

But I guess you are only interested if the perl used to run gitweb barfs with that two parameter, so the original check would be the right way.

Will apply, but I am about to go to bed, so it will be tomorrow.

Thanks.