Re: [PATCH] t9500: skip gitweb tests if perl version is too old
- From
- Sven Verdoolaege <skimo@kotnet.org>
- Date
- Jun 23, 2007, 10:51 UTC
- Message-ID
- <20070623105118.GY955MdfPADPa@greensroom.kotnet.org>
- In-Reply-To
- <7vps3n3rm7.fsf@assigned-by-dhcp.pobox.com>
On Sat, Jun 23, 2007 at 03:14:08AM -0700, Junio C Hamano wrote:
Show 7 quoted lines
> Well, "Encode::FB_CLUCK" is a bogus symbol even in recent Perl. > IOW, the tested function does not seem to care if I give > whatever garbage as the second parameter. > > But I guess you are only interested if the perl used to run > gitweb barfs with that two parameter, so the original check > would be the right way.
Indeed. gitweb doesn't use FB_CLUCK and if it did, we would want to know about it (and not skip the tests).
skimo