git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] "git-tag -s" should create a signed annotated tag

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 25, 2007, 23:21 UTC
Message-ID
<7vprxxj4hl.fsf@gitster.siamese.dyndns.org>

The earlier patch 396865859918e9c7bf8ce74aae137c57da134610 (Make builtin-tag.c use parse_options.) broke "git-tag -s".

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 * It's _very_ disturbing that the testsuite did not catch this
   breakage, even though I though we had a very detailed coverage for
   "git tag" when it was rewritten in C.
 builtin-tag.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/builtin-tag.c b/builtin-tag.c
index 3a6467d..114c684 100644
--- a/builtin-tag.c
+++ b/builtin-tag.c
@@ -398,6 +398,9 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
 
 	argc = parse_options(argc, argv, options, git_tag_usage, 0);
 
+	if (sign)
+		annotate = 1;
+
 	if (list)
 		return list_tags(list == no_pattern ? NULL : list, lines);
 	if (delete)
Next: Jeff King
Message 1 of 3 in “"git-tag -s" should create a signed annotated tag”
  1. "git-tag -s" should create a signed annotated tagJunio C Hamano, Nov 25, 2007
  2. Jeff KingNov 26, 2007
  3. Carlos RicaNov 26, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.