Re: [PATCH] "git-tag -s" should create a signed annotated tag
- From
Jeff King <peff@peff.net>
- Date
- Nov 26, 2007, 04:50 UTC
- Message-ID
- <20071126045058.GB6471@sigill.intra.peff.net>
- In-Reply-To
- <7vprxxj4hl.fsf@gitster.siamese.dyndns.org>
On Sun, Nov 25, 2007 at 03:21:42PM -0800, Junio C Hamano wrote:
> * It's _very_ disturbing that the testsuite did not catch this > breakage, even though I though we had a very detailed coverage for > "git tag" when it was rewritten in C.
Then where is the new test to accompany your patch? :P
-- >8 -- git-tag: test that -s implies an annotated tag
This detects a regression introduced while moving git-tag to a C builtin.
Signed-off-by: Jeff King <peff@peff.net> --- t/t7004-tag.sh | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh index 736f22e..c7130c4 100755 --- a/t/t7004-tag.sh +++ b/t/t7004-tag.sh @@ -667,6 +667,22 @@ test_expect_success 'creating a signed tag with -F - should succeed' ' git diff expect actual ' +cat >fakeeditor <<'EOF' +#!/bin/sh +test -n "$1" && exec >"$1" +echo A signed tag message +echo from a fake editor. +EOF +chmod +x fakeeditor +get_tag_header implied-annotate $commit commit $time >expect +./fakeeditor >>expect +echo '-----BEGIN PGP SIGNATURE-----' >>expect +test_expect_success '-s implies annotated tag' ' + GIT_EDITOR=./fakeeditor git-tag -s implied-annotate && + get_tag_msg implied-annotate >actual && + git diff expect actual +' + test_expect_success \ 'trying to create a signed tag with non-existing -F file should fail' ' ! test -f nonexistingfile &&
-- 1.5.3.6.2022.gd7807a-dirty