git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bisect: error out when given any good rev that is not an ancestor of the bad rev

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 30, 2008, 23:32 UTC
Message-ID
<7vprpyts7j.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<200807010116.30214.chriscool@tuxfamily.org>
Christian Couder <chriscool@tuxfamily.org> writes:
Show 14 quoted lines
> Le mardi 1 juillet 2008, Junio C Hamano a écrit :
>> Christian Couder <chriscool@tuxfamily.org> writes:
>> > Before this patch "git bisect" doesn't really work when it is given
>> > some good revs that are siblings of the bad rev.
>> >
>> > For example if there is the following history:
>> >
>> > A-B-C-D
>> >    \E-F
>> >
>> > and we launch "git bisect start D F" then only C and D will be
>> > considered as possible first bad commit.
>
> I am assuming the first bad commit in the graph is A and it is fixed by F.

Ah, I see your confusion here. bisect is about finding regressions. "Older ones were good, and now there is a breakage. Who broke it?"

If F fixed it, that is already outside the bisection's scope. The user needs to know that by saying F is good, he is saying he knows everything that leads to F is good.

Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 11 in “bisect: error out when given any good rev that is not an ancestor of the bad rev”
  1. bisect: error out when given any good rev that is not an ancestor of the bad revChristian Couder, Jun 30, 2008
  2. Junio C HamanoJun 30, 2008
  3. Junio C HamanoJun 30, 2008
  4. Christian CouderJun 30, 2008
  5. Junio C HamanoJun 30, 2008
  6. Junio C HamanoJun 30, 2008
  7. Junio C HamanoJun 30, 2008
  8. Christian CouderJun 30, 2008
  9. Junio C HamanoJun 30, 2008
  10. Christian CouderJul 1, 2008
  11. Junio C HamanoJul 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.