git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bisect: error out when given any good rev that is not an ancestor of the bad rev

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 30, 2008, 23:52 UTC
Message-ID
<7vej6etra7.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<200807010146.09206.chriscool@tuxfamily.org>
Christian Couder <chriscool@tuxfamily.org> writes:
> Yes, but the fact is that the user may wrongly think that F is an ancestor 
> of D or he may not remember/know about the rule that saying "F is good" 
> means "everything from A to F is good". That's why this patch adds a safety 
> net by detecting end erroring out in this case.
Yeah, sorry about the confusion earlier.

But I do not think forbidding forked topology very early in bisection process is a very good idea. The user would be at loss when told:

	echo >&2 "Maybe you mistake good and bad revs?"

Aside from the "test a trial merge" idea I floated in the other message, when we detect such a fork, perhaps we can suggest testing the merge base version (B in your picture) first? We would immediately know as the user would say "B is bad" if the topology is problematic.

Then, we can suggest the user that breakage at D may not be a regression but a longstanding bug that was recently fixed somewhere between B and F.

The user then can decide to bisect to find the fix (so that it can be cherry picked on top of D) or merge F into D to propagate the fix forward if it is not important to find out which exact commit fixed the issue.

Hmm?
Previous: Christian CouderNext: Christian Couder
Message 9 of 11 in “bisect: error out when given any good rev that is not an ancestor of the bad rev”
  1. bisect: error out when given any good rev that is not an ancestor of the bad revChristian Couder, Jun 30, 2008
  2. Junio C HamanoJun 30, 2008
  3. Junio C HamanoJun 30, 2008
  4. Christian CouderJun 30, 2008
  5. Junio C HamanoJun 30, 2008
  6. Junio C HamanoJun 30, 2008
  7. Junio C HamanoJun 30, 2008
  8. Christian CouderJun 30, 2008
  9. Junio C HamanoJun 30, 2008
  10. Christian CouderJul 1, 2008
  11. Junio C HamanoJul 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.