Re: [PATCH] builtin-commit: add --date option

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 2, 2009, 19:38 UTC
Message-ID: <7vpr6xcgki.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091202192614.GD30778@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

> Do you really want to set the date to something arbitrary, or do you
> just want to set it to "now"? If the latter case, do you really just
> want the recently discussed --reset-author?
>
> Also, is there a good reason why GIT_AUTHOR_DATE is not respected in
> this case?  If not, should we simply be fixing that bug instead?

I expect I won't be on the list for the rest of the day (I've started the preparation to tag -rc1), but I have two-and-half points before this discussion goes too far:

 - The "--reset-author" patch will be in 1.6.6 (it is already in 'master'
   yesterday, I think);

 - We should honor GIT_AUTHOR_DATE if --reset-author is given.

 - I _think_ we should ignore GIT_AUTHOR_DATE if --reset-author is not
   given, as --amend/-c/-C is stronger for being command line options than
   an environment variable.

So I do not think --date is something we urgently need, even though it might be nice to have it to be consistent with --author.