Re: [PATCH] builtin-commit: add --date option
- From
Miklos Vajna <vmiklos@frugalware.org>
- Date
- Dec 2, 2009, 22:12 UTC
- Message-ID
- <20091202221232.GF31763@genesis.frugalware.org>
- In-Reply-To
- <20091202192614.GD30778@coredump.intra.peff.net>
On Wed, Dec 02, 2009 at 02:26:14PM -0500, Jeff King <peff@peff.net> wrote:
> Do you really want to set the date to something arbitrary, or do you > just want to set it to "now"? If the latter case, do you really just > want the recently discussed --reset-author?
No, I want to set it to two days ago, for example when I forgot to commit at the end of the day and I notice it two days later before I start to work on something again.
> Also, is there a good reason why GIT_AUTHOR_DATE is not respected in > this case? If not, should we simply be fixing that bug instead?
GIT_AUTHOR_DATE is respected by --reset-author, just given that we have --author already, using environment variables for a user can be uncomfortable.