git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Performance optimization for detection of modified submodules

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 19, 2010, 18:09 UTC
Message-ID
<7vpr569dai.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4B556ED2.7020904@web.de>
Jens Lehmann <Jens.Lehmann@web.de> writes:
Show 6 quoted lines
> I am working on a subsequent patch where dirty_submodule is used as a
> bitfield to store more detailed information about the dirtiness. That is
> then used by "git diff --submodule" to tell the user if the submodule
> contains untracked and/or modified files.
>
> But i can revert that part if you want.

"Will be used as bitfield in later patches" is a justification that was missing; with that I think the patch is Ok as-is.

Show 5 quoted lines
>> Mental note to myself.  prefix[0] is either '-' (removed from the work
>> tree) or '+' (added to the work tree).  Added submodule could be
>> immediately dirty.
>
> Should i add a comment there?
Meh, that was just me thinking aloud.
Thanks.
Previous: Jens Lehmann
Message 4 of 4 in “Performance optimization for detection of modified submodules”
  1. Performance optimization for detection of modified submodulesJens Lehmann, Jan 18, 2010
  2. Junio C HamanoJan 19, 2010
  3. Jens LehmannJan 19, 2010
  4. Junio C HamanoJan 19, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.