From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 19 Jan 2010 18:09:57 GMT
Subject: Re: [PATCH v2] Performance optimization for detection of modified submodules
Message-ID: <7vpr569dai.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4B556ED2.7020904@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

> I am working on a subsequent patch where dirty_submodule is used as a
> bitfield to store more detailed information about the dirtiness. That is
> then used by "git diff --submodule" to tell the user if the submodule
> contains untracked and/or modified files.
>
> But i can revert that part if you want.

"Will be used as bitfield in later patches" is a justification that was
missing; with that I think the patch is Ok as-is.

>> Mental note to myself.  prefix[0] is either '-' (removed from the work
>> tree) or '+' (added to the work tree).  Added submodule could be
>> immediately dirty.
>
> Should i add a comment there?

Meh, that was just me thinking aloud.

Thanks.