git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/3] push: Add the --no-recurse-submodules option

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 1, 2011, 01:16 UTC
Message-ID
<7vpqkqj5h7.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4E3315E6.8060501@web.de>
Jens Lehmann <Jens.Lehmann@web.de> writes:
Show 5 quoted lines
> We will skip the check for submodules without remotes, does that lessen
> your annoyance? We still think it is a good idea to have that test enabled
> by default, but it might be a good idea to wait with that until we provide
> a central config option to enable users to turn that off with a simple
> "git config push.recurseSubmodules off". What do you think?

I would rather see a questionable (in the sense that it can trigger false positive and annoy users of workflows you didn't anticipate) new feature turned off by default, so that interested people who _do_ want to can use it knowing what they are getting into, to find out as much unexpected fallout as possible. So if we want to give this topic early graduation, I would suggest making it a command line option that defaults to off first, then in a later commit add a configuration option to enable people to turn it on (and allow those who do not see the point of the new feature to keep it turned off permanently). Enabling the feature by default can be done in a later version after the feature proves to be truly useful for people who opted into the experiment.

Previous: Jens LehmannNext: Junio C Hamano
Message 8 of 10 in “check for unpushed remotes in submodules”
  1. 0/3 check for unpushed remotes in submodulesFredrik Gustafsson, Jul 27, 2011
  2. 1/3 test whether push checks for unpushed remotes in submodulesFredrik Gustafsson, Jul 27, 2011
  3. 2/3 push: Don't push a repository with unpushed submodulesFredrik Gustafsson, Jul 27, 2011
  4. 3/3 push: Add the --no-recurse-submodules optionFredrik Gustafsson, Jul 27, 2011
  5. Junio C HamanoJul 28, 2011
  6. Jens LehmannJul 28, 2011
  7. Jens LehmannJul 29, 2011
  8. Junio C HamanoAug 1, 2011
  9. Junio C HamanoJul 28, 2011
  10. Jens LehmannJul 28, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.