git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/3] push: Add the --no-recurse-submodules option

From
Jens Lehmann <jens.lehmann@web.de>
Date
Jul 28, 2011, 22:22 UTC
Message-ID
<4E31E140.8020105@web.de>
In-Reply-To
<7vy5zikw6e.fsf@alter.siamese.dyndns.org>
Am 28.07.2011 22:05, schrieb Junio C Hamano:
Show 9 quoted lines
> Fredrik Gustafsson <iveqy@iveqy.com> writes:
> 
>> This adds the option --no-recurse-submodules to push. That is, git
> 
> I think this needs to be renamed at least for two reasons.
> 
> The name makes it sound as if "push --recurse-submodules" would
> recursively visit the submodules and runs "push" there, but I do not think
> that is what this flag does.
That is because the patch that does this is still in the making ;-)

The cover letter should have mentioned it, but we talked about making push pretty symmetric to fetch:

- Use "--no-recurse-submodules" if you don't want submodules to be pushed
  (we added that right now so users can disable the behavior the second
  commit introduces)
- Use "--recurse-submodules=on-demand" to push only those submodules where
  new commits have been recorded in the superproject's refs to be pushed
- Use "--recurse-submodules" to unconditionally push everything in the
  submodules too
- Make the default configurable by a "push.recurseSubmodules" option

We'll need another round to discuss how to handle private submodules which were never intended to be pushed, but I think the general idea of having fetch and push use similar options makes sense, no?

Previous: Junio C HamanoNext: Jens Lehmann
Message 6 of 10 in “check for unpushed remotes in submodules”
  1. 0/3 check for unpushed remotes in submodulesFredrik Gustafsson, Jul 27, 2011
  2. 1/3 test whether push checks for unpushed remotes in submodulesFredrik Gustafsson, Jul 27, 2011
  3. 2/3 push: Don't push a repository with unpushed submodulesFredrik Gustafsson, Jul 27, 2011
  4. 3/3 push: Add the --no-recurse-submodules optionFredrik Gustafsson, Jul 27, 2011
  5. Junio C HamanoJul 28, 2011
  6. Jens LehmannJul 28, 2011
  7. Jens LehmannJul 29, 2011
  8. Junio C HamanoAug 1, 2011
  9. Junio C HamanoJul 28, 2011
  10. Jens LehmannJul 28, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.