Re: [PATCH 2/3] Fix some "variable might be used uninitialized" warnings
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 11, 2011, 20:48 UTC
- Message-ID
- <7vpqj6olfa.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4E6D0E74.1020801@ramsay1.demon.co.uk>
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
Show 11 quoted lines
> In particular, gcc complains as follows: > > CC tree-walk.o > tree-walk.c: In function `traverse_trees': > tree-walk.c:347: warning: 'e' might be used uninitialized in this \ > function > > CC builtin/revert.o > builtin/revert.c: In function `verify_opt_mutually_compatible': > builtin/revert.c:113: warning: 'opt2' might be used uninitialized in \ > this function
Could you also add something to this effect to the commit log message:
but I have verified that these are gcc being not careful enough and they are never used uninitialized.
If that is what you indeed have done, that is.
Thanks.