From: Junio C Hamano Date: Sun, 11 Sep 2011 20:48:09 GMT Subject: Re: [PATCH 2/3] Fix some "variable might be used uninitialized" warnings Message-ID: <7vpqj6olfa.fsf@alter.siamese.dyndns.org> In-Reply-To: <4E6D0E74.1020801@ramsay1.demon.co.uk> Ramsay Jones writes: > In particular, gcc complains as follows: > > CC tree-walk.o > tree-walk.c: In function `traverse_trees': > tree-walk.c:347: warning: 'e' might be used uninitialized in this \ > function > > CC builtin/revert.o > builtin/revert.c: In function `verify_opt_mutually_compatible': > builtin/revert.c:113: warning: 'opt2' might be used uninitialized in \ > this function Could you also add something to this effect to the commit log message: but I have verified that these are gcc being not careful enough and they are never used uninitialized. If that is what you indeed have done, that is. Thanks.