git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] MSVC: Do not close stdout to prevent a crash

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 20, 2011, 03:27 UTC
Message-ID
<7vpqgniid5.fsf@alter.siamese.dyndns.org>
In-Reply-To
<m2obw7dg1e.fsf@igel.home>
Andreas Schwab <schwab@linux-m68k.org> writes:
Show 6 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> We have relied on fstat(-1, &st) to correctly error out, and if MSVC build
>> crashes, it is a bug in its fstat() emulation, I would think.
>
> fileno(stdout) is alread wrong if stdout was closed.
The "-1" in my message comes from here:
    DESCRIPTION
    The fileno() function shall return the integer file descriptor
    associated with the stream pointed to by stream.
    RETURN VALUE
    Upon successful completion, fileno() shall return the integer value of
    the file descriptor associated with stream. Otherwise, the value -1
    shall be returned and errno set to indicate the error.
Previous: Andreas SchwabNext: Andreas Schwab
Message 6 of 14 in “MSVC: Do not close stdout to prevent a crash”
  1. 1/2 MSVC: Do not close stdout to prevent a crashVincent van Ravesteijn, Nov 19, 2011
  2. 2/2 MSVC: Use _putenv instead of putenv to prevent a crashVincent van Ravesteijn, Nov 19, 2011
  3. Andreas SchwabNov 19, 2011
  4. Junio C HamanoNov 19, 2011
  5. Andreas SchwabNov 19, 2011
  6. Junio C HamanoNov 20, 2011
  7. Andreas SchwabNov 20, 2011
  8. Johannes SixtNov 20, 2011
  9. Junio C HamanoNov 20, 2011
  10. Vincent van RavesteijnNov 19, 2011
  11. Johannes SixtNov 19, 2011
  12. Vincent van RavesteijnNov 22, 2011
  13. Johannes SixtNov 22, 2011
  14. Vincent van RavesteijnNov 22, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.