From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 20 Nov 2011 03:27:02 GMT
Subject: Re: [PATCH 1/2] MSVC: Do not close stdout to prevent a crash
Message-ID: <7vpqgniid5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <m2obw7dg1e.fsf@igel.home>

Andreas Schwab <schwab@linux-m68k.org> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> We have relied on fstat(-1, &st) to correctly error out, and if MSVC build
>> crashes, it is a bug in its fstat() emulation, I would think.
>
> fileno(stdout) is alread wrong if stdout was closed.

The "-1" in my message comes from here:

    DESCRIPTION

    The fileno() function shall return the integer file descriptor
    associated with the stream pointed to by stream.

    RETURN VALUE

    Upon successful completion, fileno() shall return the integer value of
    the file descriptor associated with stream. Otherwise, the value -1
    shall be returned and errno set to indicate the error.