git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] t4041 (diff-submodule-option): change tense of test names

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 27, 2012, 17:51 UTC
Message-ID
<7vpq2zlyrm.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1354005692-2809-5-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra <artagnon@gmail.com> writes:
Show 5 quoted lines
> Change the tense of test names from past to present, as this is the
> prevalent style.
>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---

I see most of them are not "past" but "past particle" used as if they are adjectives.

For example, I think this test
> -test_expect_success 'added submodule' '
tries to say "See what happens to an added submodule".
The same for the others.
> -test_expect_success 'modified submodule(forward)' '
"See what is shown for modified submodule."
> -test_expect_success 'typechanged submodule(submodule->blob), --cached' '

"See what is shown for typechanged one, when --cached option is given".

So I do not think this patch is needed; the current wording looks not so grammatically kosher, but still is understandable. Updated result isn't.

Previous: Ramkumar Ramachandra
Message 8 of 8 in “t4041 (diff-submodule-option): minor cleanup”
  1. 0/4 t4041 (diff-submodule-option): minor cleanupRamkumar Ramachandra, Nov 27, 2012
  2. 1/4 t4041 (diff-submodule-option): parse digests sensiblyRamkumar Ramachandra, Nov 27, 2012
  3. Junio C HamanoNov 27, 2012
  4. 2/4 t4041 (diff-submodule-option): rewrite add_file() routineRamkumar Ramachandra, Nov 27, 2012
  5. Junio C HamanoNov 27, 2012
  6. 3/4 t4041 (diff-submodule-option): modernize styleRamkumar Ramachandra, Nov 27, 2012
  7. 4/4 t4041 (diff-submodule-option): change tense of test namesRamkumar Ramachandra, Nov 27, 2012
  8. Junio C HamanoNov 27, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.