From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 27 Nov 2012 17:51:57 GMT
Subject: Re: [PATCH 4/4] t4041 (diff-submodule-option): change tense of test names
Message-ID: <7vpq2zlyrm.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1354005692-2809-5-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> Change the tense of test names from past to present, as this is the
> prevalent style.
>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---

I see most of them are not "past" but "past particle" used as if
they are adjectives.

For example, I think this test

> -test_expect_success 'added submodule' '

tries to say "See what happens to an added submodule".

The same for the others.

> -test_expect_success 'modified submodule(forward)' '

"See what is shown for modified submodule."

> -test_expect_success 'typechanged submodule(submodule->blob), --cached' '

"See what is shown for typechanged one, when --cached option is
given".

So I do not think this patch is needed; the current wording looks
not so grammatically kosher, but still is understandable.  Updated
result isn't.