Re: [PATCH 09/13] contrib/subtree: Ignore testing directory

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 5, 2013, 04:36 UTC
Message-ID: <7vpq0fxtpp.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1360037173-23291-10-git-send-email-greened@obbligato.org>

"David A. Greene" <greened@obbligato.org> writes:

> From: Techlive Zheng <techlivezheng@gmail.com>
>

Justification is missing here.

contrib/subtree/Makefile seems to do "rm -rf" on 'mainline' and 'subproj' in its "clean" target, which makes them look like build/test artifacts that need to be ignored.

If they are no longer build/test artifacts, perhaps their removal also need to be dropped from the Makefile?

Show 19 quoted lines

> Signed-off-by: Techlive Zheng <techlivezheng@gmail.com>
> Signed-off-by: David A. Greene <greened@obbligato.org>
> ---
>  contrib/subtree/.gitignore |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/contrib/subtree/.gitignore b/contrib/subtree/.gitignore
> index 91360a3..59aeeb4 100644
> --- a/contrib/subtree/.gitignore
> +++ b/contrib/subtree/.gitignore
> @@ -1,6 +1,5 @@
>  *~
>  git-subtree
> -git-subtree.xml
>  git-subtree.1
> -mainline
> -subproj
> +git-subtree.xml
> +t/trash\ directory.*