Re: [PATCH 11/13] contrib/subtree: Make each test self-contained

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 5, 2013, 15:18 UTC
Message-ID: <7v4nhqwzzi.fsf@alter.siamese.dyndns.org>
In-Reply-To: <87d2wfrnbe.fsf@waller.obbligato.org>

greened@obbligato.org writes:

Show 14 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> "David A. Greene" <greened@obbligato.org> writes:
>>
>>> +test_create_commit() (
>>> +	repo=$1
>>> +	commit=$2
>>> +	cd "$repo"
>>> +	mkdir -p "$(dirname "$commit")"
>>> +	echo "$commit" > "$commit"
>>
>> Style.
>
> I need a little more explanation.  :)  Is there a style guide somewhere?

Documentation/CodingGuidelines?

Show 11 quoted lines

>
>>> +	git add "$commit"
>>> +	git commit -m "$commit"
>>> +)
>>
>> Very nice, but don't we want to check for possible errors in any of
>> the above commands?
>
> I'll fix that.  :)
> ...
> Ok.  I'll rework this.

Thanks.

I also think it would be a good idea for you to learn to push back to the original authors; fixing problems in patches by others, while is a good way to learn how their thinking process went, is not necessarily fun.