Re: [PATCH v2 2/2] send-email: introduce sendemail.smtpsslcertpath
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 7, 2013, 04:12 UTC
- Message-ID
- <7vppuv57ps.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20130706114600.GP9161@serenity.lan>
John Keeping <john@keeping.me.uk> writes:
Show 10 quoted lines
> @@ -1096,19 +1101,18 @@ sub smtp_auth_maybe {
> # Helper to come up with SSL/TLS certification validation params
> # and warn when doing no verification
> sub ssl_verify_params {
> - use IO::Socket::SSL qw(SSL_VERIFY_PEER SSL_VERIFY_NONE);
> -
> - if (!defined $smtp_ssl_cert_path) {
> - $smtp_ssl_cert_path = "/etc/ssl/certs";
> + if ($smtp_ssl_verify == 0) {
> + return (SSL_verify_mode => IO::Socket::SSL->SSL_VERIFY_NONE);I do not see any "use IO::Socket::SSL" anywhere after applying this patch. Is this expected to work?