Re: [PATCH v2 2/2] send-email: introduce sendemail.smtpsslcertpath

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Jul 5, 2013, 20:29 UTC
Message-ID: <20130705202948.GW862789@vauxhall.crustytoothpaste.net>
In-Reply-To: <7vobag7wl0.fsf@alter.siamese.dyndns.org>

On Fri, Jul 05, 2013 at 10:20:11AM -0700, Junio C Hamano wrote:

> +# Helper to come up with SSL/TLS certification validation params
> +# and warn when doing no verification
> +sub ssl_verify_params {
> +	use IO::Socket::SSL qw(SSL_VERIFY_PEER SSL_VERIFY_NONE);

You might as well put this at the top of the file, because all use statements happen at compile time anyway, regardless of their location. If you want to lazy-load this, you need to do:

require IO::Socket::SSL; IO::Socket::SSL->import(qw(SSL_VERIFY_PEER SSL_VERIFY_NONE));

which is equivalent to "use" except that it happens at runtime.

Otherwise, it looks fine.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187