Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 15, 2013, 19:49 UTC
- Message-ID
- <7vppuja9ip.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <51E2CE97.2040900@gmail.com>
Mark Levedahl <mlevedahl@gmail.com> writes:
Show 23 quoted lines
>> In order to limit the adverse effects caused by this implementation, >> we provide a new "fast stat" interface, which allows us to use this >> only for interactions with the index (i.e. the cached stat data). >> >> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> >> --- > > I've tested this on Cygwin 1.7 on WIndows 7 , comparing to the results > using your prior patch (removing the Cygwin specific lstat entirely) > and get the same results with both, so this seems ok from me. > > My comparison point was created by reverting your current patch from > pu, then reapplying your earlier patch on top, so the only difference > was which approach was used to address the stat functions. > > Caveats: > 1) I don't find any speed improvement of the current patch over the > previous one (the tests actually ran faster with the earlier patch, > though the difference was less than 1%). > 2) I still question this whole approach, especially having this > non-POSIX compliant mode be the default. Running in this mode breaks > interoperability with Linux, but providing a Linux environment is the > *primary* goal of Cygwin.
Sounds like we are better off without this patch, and instead remove the "schizophrenic stat"? I do not have a strong opinion either way, except that I tend to agree with your point 2) above.