Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

From: Mark Levedahl <mlevedahl@gmail.com>
Date: Jul 16, 2013, 03:54 UTC
Message-ID: <51E4C400.6000009@gmail.com>
In-Reply-To: <51E4AABD.9010701@web.de>

On 07/15/2013 10:06 PM, Torsten Bögershausen wrote:

Show 25 quoted lines

> On 2013-07-15 21.49, Junio C Hamano wrote:
>> Mark Levedahl <mlevedahl@gmail.com> writes:
>>
>>>> In order to limit the adverse effects caused by this implementation,
>>>> we provide a new "fast stat" interface, which allows us to use this
>>>> only for interactions with the index (i.e. the cached stat data).
>>>>
>>>> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
>>>> ---
>>> I've tested this on Cygwin 1.7 on WIndows 7 , comparing to the results
>>> using your prior patch (removing the Cygwin specific lstat entirely)
>>> and get the same results with both, so this seems ok from me.
>>>
>>> My comparison point was created by reverting your current patch from
>>> pu, then reapplying your earlier patch on top, so the only difference
>>> was which approach was used to address the stat functions.
>>>
>>> Caveats:
>>> 1) I don't find any speed improvement of the current patch over the
>>> previous one (the tests actually ran faster with the earlier patch,
>>> though the difference was less than 1%).
> Hm, measuring the time for the test suite is one thing,
> did you measure the time of "git status" with and without the patch?
>
> (I don't have my test system at hand, so I can test in a few days/weeks)

Timing for 5 rounds of "git status" in the git project. First, with the current fast_lstat patches: /usr/local/src/git>for i in {1..5} ; do time git status >& /dev/null ; done

real 0m0.218s user 0m0.000s sys 0m0.218s

real 0m0.187s user 0m0.077s sys 0m0.109s

real 0m0.187s user 0m0.030s sys 0m0.156s

real 0m0.203s user 0m0.031s sys 0m0.171s

real 0m0.187s user 0m0.062s sys 0m0.124s

Now, with Ramsay's original patch just removing the non-Posix stat functions: /usr/local/src/git>for i in {1..5} ; do time git status >& /dev/null ; done

real 0m0.218s user 0m0.046s sys 0m0.171s

real 0m0.187s user 0m0.015s sys 0m0.171s

real 0m0.187s user 0m0.047s sys 0m0.140s

real 0m0.187s user 0m0.031s sys 0m0.156s

I see no difference in the above. (Yes, I checked multiple times that I was using different executables).

Show 16 quoted lines

>>> 2) I still question this whole approach, especially having this
>>> non-POSIX compliant mode be the default. Running in this mode breaks
>>> interoperability with Linux, but providing a Linux environment is the
>>> *primary* goal of Cygwin.
>> Sounds like we are better off without this patch, and instead remove
>> the "schizophrenic stat"?  I do not have a strong opinion either
>> way, except that I tend to agree with your point 2) above.
> My understanding is that we want both:
> Introduction of fast_lstat() as phase 1,
> and the removal of the "schizophrenic stat" in compat/cygwin.c
> as phase 2. (or do I missunderstand something ?)
>
>
> And yes, phase 3:
> The day we have a both reliable and fast
> lstat() in cygwin, we can remove compat/cygwin.[ch]

If you know how to make Cygwin's stat faster while maintaining Posix semantics, please post a patch to the Cygwin list, they would *love* it.

Mark