Re: speeding up cg-log -u

From: Junio C Hamano <junkio@cox.net>
Date: May 16, 2005, 08:13 UTC
Message-ID: <7voebboafy.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.21.0505151158300.30848-100000@iabervon.org>

>>>>> "DB" == Daniel Barkalow <barkalow@iabervon.org> writes:

DB> Existance is the primary thing, and everything else was added as DB> needed. (Pure connectivity is a bit special, because it's a property of DB> generic objects so that fsck-cache doesn't need to know about particular DB> types of objects unless there are particular things to check about them)

DB> If you need more fields, let me know, and I'll figure out how to include DB> them.

Could you take a look at the latest round of the patch and see what I did there makes sense?

    From: Junio C Hamano <junkio@cox.net>
    Date: Sun, 15 May 2005 14:18:36 -0700
    Message-ID: <7vy8agqjbn.fsf@assigned-by-dhcp.cox.net>
    Subject: [PATCH 1/4] Add --author and --committer match
             to git-rev-list and git-rev-tree.

Another thing I wanted to ask you about was lifetime rules. When we "lookup" these objects (and then "parse" them, which causes more memory to be used), who is responsible for freeing them? When my program thinks it is done with a commit, is it allowed to free it? Or does the lookup machinery own all of the objects that have ever been looked up, and the program should not worry about freeing them to begin with?