Re: speeding up cg-log -u
- From
Petr Baudis <pasky@ucw.cz>
- Date
- May 14, 2005, 14:40 UTC
- Message-ID
- <20050514144057.GH3905@pasky.ji.cz>
- In-Reply-To
- <20050514142325.GC14353@tumblerings.org>
Dear diary, on Sat, May 14, 2005 at 04:23:25PM CEST, I got a letter where Zack Brown <zbrown@tumblerings.org> told me that...
Show 12 quoted lines
> On Sat, May 14, 2005 at 04:17:44AM -0700, Junio C Hamano wrote: > > Not wanting to keep the whole object because of their size is > > understandable since the users of "struct object" derivatives > > rarely if ever seem to free them once they get hold of them. > > And not wanting to think ahead about what is worth keeping (like > > names for tree entries back then, or commit author names) is > > also understandable, but it still is frustrating. > > So if this design is changed to suit -u, would a further redesign be needed > to support an option to filter on keywords in the body of the changelog > entry? Perhaps this will result in a net slowdown for the usual case of just > grabbing all log entries.
I admit not looking at this code for a rather long time, but what about just telling the commit parser what stuff are you interested in and it would leave the rest of the structure fields NULL? That would mean only slight memory usage increase and basically no time increase.
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor