Re: [PATCH] Pass -DDEFAULT_GIT_TEMPLATE_DIR only where actually used.
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jun 22, 2006, 17:11 UTC
- Message-ID
- <7vodwlp12i.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20060622131235.GA21864@pasky.or.cz>
Petr Baudis <pasky@suse.cz> writes:
Show 9 quoted lines
> Dear diary, on Thu, Jun 22, 2006 at 09:19:52AM CEST, I got a letter > where Junio C Hamano <junkio@cox.net> said that... >> For that matter, I do not think tracking prefix_SQ makes much >> sense since what matters are bindir, gitexecdir and template_dir >> which are already covered, and prefix is merely a convenience to >> set these three (four, counting GIT_PYTHON_DIR; we probably >> should add it to TRACK_CFLAGS). > > $(prefix) will be passed to perl/Makefile.PL.
Then probably it shouldn't; instead we woulld probably want to pass the moral equivalent of GIT_PYTHON_DIR.