Re: [PATCH] Pass -DDEFAULT_GIT_TEMPLATE_DIR only where actually used.
- From
- Timo Hirvonen <tihirvon@gmail.com>
- Date
- Jun 22, 2006, 07:49 UTC
- Message-ID
- <20060622104901.f3543f07.tihirvon@gmail.com>
- In-Reply-To
- <7vwtb9veqv.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
Show 16 quoted lines
> Yakov Lerner <iler.ml@gmail.com> writes: > > > Before this patch, -DDEFAULT_GIT_TEMPLATE_DIR was passed on compilation > > command line to all and every %c compiled. In fact the macro > > is used by only one .c file, and unused by all other .c files. > > Remove -DDEFAULT_GIT_TEMPLATE_DIR where unused. Follow the examlpe of > > exec_cmd.o. Pass -DDEFAULT_GIT_TEMPLATE_DIR only where actually used. > > Thanks. > > By the way, I really started hating that we have $(GIT_VERSION) > in $(TRACK_CFLAGS). Since the version string is tied to the > HEAD commit object name, having it in $(TRACK_CFLAGS) means that > every time I switch branches, make a new commit on top of the > current branch, or checkout-compile-and-then-make-local-change > sequence would force pretty much everything to be rebuilt.
I think this already makes sure git is compiled if version changes:
# These can record GIT_VERSION
git$X git.spec \
$(patsubst %.sh,%,$(SCRIPT_SH)) \
$(patsubst %.perl,%,$(SCRIPT_PERL)) \
$(patsubst %.py,%,$(SCRIPT_PYTHON)) \
: GIT-VERSION-FILE$ git grep GIT_VERSION *.sh *.perl git-send-email.perl: my $gitversion = '@@GIT_VERSION@@'; git-send-email.perl: if ($gitversion =~ m/..GIT_VERSION../) {
Only git-send-email and git needs to depend on GIT_VERSION.
Show 5 quoted lines
> For that matter, I do not think tracking prefix_SQ makes much > sense since what matters are bindir, gitexecdir and template_dir > which are already covered, and prefix is merely a convenience to > set these three (four, counting GIT_PYTHON_DIR; we probably > should add it to TRACK_CFLAGS).
Yes, only ALL_CFLAGS, bindir, gitexecdir, template_dir and GIT_PYTHON_DIR should be in TRACK_CFLAGS.
-- http://onion.dynserv.net/~timo/