git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/6] gitweb: Link to associated tree from a particular log item in full log view

From
Junio C Hamano <junkio@cox.net>
Date
Sep 23, 2006, 00:44 UTC
Message-ID
<7vodt7xvgu.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20060922231315.GD8259@pasky.or.cz>
Petr Baudis <pasky@suse.cz> writes:
Show 21 quoted lines
> Oops. It's trivial typo:
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index d2366c7..c5f3810 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -2880,7 +2880,7 @@ sub git_log {
>  		      " | " .
>  		      $cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") .
>  		      " | " .
> -		      $cgi->a({-href => href(action=>"tree", hash=>$commit), hash_base=>$commit}, "tree") .
> +		      $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree") .
>  		      "<br/>\n" .
>  		      "</div>\n" .
>  		      "<i>" . esc_html($co{'author_name'}) .  " [$ad{'rfc2822'}]</i><br/>\n" .
>
>> You do not have the tree object name available in git_log to
>> generate an URL with both h and hb, and getting to it is an
>> extra work.
>
> Well using commit hash as a tree id works just fine...

I agree that change is much safer. Will apply with an appropriate log message and attribution. No need to resend.

Previous: Petr BaudisNext: Jakub Narebski
Message 7 of 12 in “gitweb: More per-view navigation bar links”
  1. 1/6 gitweb: More per-view navigation bar linksPetr Baudis, Sep 22, 2006
  2. 2/6 gitweb: Link to tree instead of snapshot in shortlogPetr Baudis, Sep 22, 2006
  3. 3/6 gitweb: Link to latest tree from the head line in heads listPetr Baudis, Sep 22, 2006
  4. 4/6 gitweb: Link to associated tree from a particular log item in full log viewPetr Baudis, Sep 22, 2006
  5. Junio C HamanoSep 22, 2006
  6. Petr BaudisSep 22, 2006
  7. Junio C HamanoSep 23, 2006
  8. Jakub NarebskiSep 23, 2006
  9. 5/6 gitweb: Rename "plain" labels to "raw"Petr Baudis, Sep 22, 2006
  10. Jakub NarebskiSep 22, 2006
  11. Petr BaudisSep 22, 2006
  12. 6/6 gitweb: Relabel "head" as "HEAD"Petr Baudis, Sep 22, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.