Re: [PATCH 4/6] gitweb: Link to associated tree from a particular log item in full log view

From: Junio C Hamano <junkio@cox.net>
Date: Sep 22, 2006, 04:18 UTC
Message-ID: <7vmz8s7cvy.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060922011948.15909.59511.stgit@rover>

I presume you are running this version at repo.or.cz, but

(1) go to http://repo.or.cz/?p=stgit.git;a=log (2) pick "tree" of one of the commits (3) go browser-back, then pick "tree" from the top navbar

The resulting tree view of (2) lacks navbar while (3) looks much saner.

You do not have the tree object name available in git_log to generate an URL with both h and hb, and getting to it is an extra work.

This would fix this particular breakage.

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 34ef3fc..8c0fdf3 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2732,9 +2732,9 @@ sub git_tree {
 			my $base = $hash_base || $hash;
 			$hash = git_get_hash_by_path($base, $file_name, "tree");
 		}
-		if (!defined $hash_base) {
-			$hash_base = $hash;
-		}
+	}
+	if (!defined $hash_base) {
+		$hash_base = $hash;
 	}
 	$/ = "\0";
 	open my $fd, "-|", git_cmd(), "ls-tree", '-z', $hash