Re: [PATCH] Bisect visualize: use "for-each-ref" to list all good refs.

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 14, 2007, 08:11 UTC
Message-ID: <7voddxkzzw.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071114055036.2c5ae793.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

> In bisect_visualize, "cd $GIT_DIR/refs && echo bisect/good-*" was
> still used instead of "git for-each-ref". This patch fix it.

Heh, it still uses

	echo "$rev" >"$GIT_DIR/refs/bisect/$tag"

So we are still _very_ much tied to refs on the filesystem not in packed-refs.

Even worse is that bisect_clean_state uses

	rm -fr "$GIT_DIR/refs/bisect"

so if you ever pack your refs in the middle of bisection and then clean the state, you will still carry the old good set of commits that are somewhat hard to cull.