Re: [PATCH] Bisect visualize: use "for-each-ref" to list all good refs.

From: Christian Couder <chriscool@tuxfamily.org>
Date: Nov 15, 2007, 06:43 UTC
Message-ID: <200711150743.59716.chriscool@tuxfamily.org>
In-Reply-To: <7voddxkzzw.fsf@gitster.siamese.dyndns.org>

Le mercredi 14 novembre 2007, Junio C Hamano a écrit :

Show 10 quoted lines

> Christian Couder <chriscool@tuxfamily.org> writes:
> > In bisect_visualize, "cd $GIT_DIR/refs && echo bisect/good-*" was
> > still used instead of "git for-each-ref". This patch fix it.
>
> Heh, it still uses
>
> 	echo "$rev" >"$GIT_DIR/refs/bisect/$tag"
>
> So we are still _very_ much tied to refs on the filesystem not
> in packed-refs.

Yes, but someone (guess who) started to modernize git-bisect by using "for-each-ref":

http://git.kernel.org/?p=git/git.git;a=commitdiff;h=6fecf1915c5fd0b14e2ca2ec9e1a6b620abfb5c2 http://git.kernel.org/?p=git/git.git;a=commitdiff;h=0a5280a9f444c33b0e4ebf2f073df5899c112cf8

so I thought it would be fine to finish this modernization work.

Show 7 quoted lines

> Even worse is that bisect_clean_state uses
>
> 	rm -fr "$GIT_DIR/refs/bisect"
>
> so if you ever pack your refs in the middle of bisection and
> then clean the state, you will still carry the old good set of
> commits that are somewhat hard to cull.

Thanks for reminding me of this problem. I just posted a patch that should fix it.

Best regards, Christian.