[PATCH 1/3] git-bisect: war on "sed"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 15, 2007, 09:00 UTC
- Message-ID
- <7voddv6fxz.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20071115081807.06fe092b.chriscool@tuxfamily.org>
We do not need to pipe "echo" to "sed" only to strip refs/heads/ from the beginning. We are assuming not-so-ancient shells these days.
Also there is no need to avoid assuming \012 is the LF; we do not run on EBCDIC, sorry. Other parts of the script already uses tr to convert separator to LF that way.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- git-bisect.sh | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/git-bisect.sh b/git-bisect.sh index 46a7b8d..3a21033 100755 --- a/git-bisect.sh +++ b/git-bisect.sh @@ -71,7 +71,7 @@ bisect_start() { ;; refs/heads/*) [ -s "$GIT_DIR/head-name" ] && die "won't bisect on seeked tree" - echo "$head" | sed 's#^refs/heads/##' >"$GIT_DIR/head-name" + echo "${head#refs/heads/}" >"$GIT_DIR/head-name" ;; *) die "Bad HEAD - strange symbolic ref" @@ -275,8 +275,7 @@ exit_if_skipped_commits () { if expr "$_tried" : ".*[|].*" > /dev/null ; then echo "There are only 'skip'ped commit left to test." echo "The first bad commit could be any of:" - echo "$_tried" | sed -e 's/[|]/\ -/g' + echo "$_tried" | tr '[|]' '[\012]' echo "We cannot bisect more!" exit 2 fi
-- 1.5.3.5.1780.gca2b